Add loadtest sendV2
#1331
Add loadtest sendV2
#1331
Conversation
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
4054555 to
fd3390e
Compare
Pull Request Test Coverage Report for Build 13240248514Details
💛 - Coveralls |
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
fd3390e to
84cb596
Compare
|
Rebased on |
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
One question/concern about repeatability of this test, other than that looks good to me.
itest/loadtest/send_test.go
Outdated
|
|
||
| // Let's make sure Bob is aware of all the assets that Alice may have | ||
| // minted. | ||
| itest.SyncUniverses(ctx, t, bob, alice, uniHost, cfg.TestTimeout) |
There was a problem hiding this comment.
I think we probably have to add a new parameter to this function that allows us to sync transfer proofs as well.
When I ran this test a second time after running 1 mintV2 and 1 sendV2 test, this sync never completed, because it only tried syncing issuance proofs.
There was a problem hiding this comment.
Didn't run into this on my tests, the sync here is done for Bob to be able to create addresses for an asset he may not be aware of yet.
About transfer proofs, I believe both universes are in sync as the proof courier option takes care of that.
I did add a new commit that allows specifying a sync mode on itest.SyncUniverses and converted this call to a full-sync
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
2 times, most recently
from
af0ace6 to
48fd69f
Compare
|
Lit PR that updates to this latest commit of tapd |
We could make it a functional option to not break other code... |
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
48fd69f to
42d2fd8
Compare
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
42d2fd8 to
09448fc
Compare
This commit adds a refactored version of the send test, which uses less assertions and rpc calls. This is meant to speed things up compared to the old test, plus offer some more coverage by utilizing normal assets and balances greater than 1 (case for collectibles).
GeorgeTsagk
force-pushed
the
loadtest-send-v2
branch
from
09448fc to
642ec6f
Compare
4 participants
Based on #1285
This PR adds the last 2 commits.
Description
This PR adds a new refactored send test for our loadtest suite, `sendV2.
The new send test uses normal assets which may have balances greater than
1(case for collectibles), which offers a bit more coverage for our code (coin selection, psbt signing, etc).Compared to the original send test, we strip away any non-mandatory assertions and RPC calls, keeping them to the minimum required to make things happen.